Repository navigation
Conversation
…tall sgl-project#44379 dropped the gfx1250 revert block that followed `pip install -r requirements.txt` but kept its trailing backslash, so the next COPY --from=local_src instruction was parsed as pip arguments and the AITER step failed with "no such option: --from" on every ROCm image.
michaelzhang-ai
requested review from
Fridge003,
HaiShaw,
ishandhanani,
ispobock and
sogalin
as code owners
October 15, 2026 17:46
michaelzhang-ai
changed the title
michaelzhang-ai
had a problem deploying
to
prod
October 15, 2026 17:57 — with 
GitHub Actions
Failure
GitHub Actions
Failure
ROCm/aiter#6042, sgl-project#5967 and sgl-project#6007 are all ancestors of the AITER pin from sgl-project#44379, so the sgl-project#6042 cherry-pick conflicts in pa_decode_sparse.py and fails the AITER step on gfx942/gfx950. The sgl-project#5967 CSV diff and the group32 other=127 sed (whose file no longer exists) are stale for the same reason.
michaelzhang-ai
changed the title
HaiShaw
approved these changes
Oct 15, 2026
michaelzhang-ai
added a commit
to michaelzhang-ai/sglang
that referenced
this pull request
Oct 15, 2026
… commit sgl-project#44534 dropped the sgl-project#6042 cherry-pick on the premise that the 2bb549102 pin already contains it. It does not: the pin (Oct 10) predates the sgl-project#6042 merge (Oct 13). The PR-branch commit 042a28918 conflicts because ROCm/aiter#6159 rewrote pa_decode_sparse.py between the old and new pins. The squash-merge commit 57e2c6b42 sits on top of sgl-project#6159 and applies cleanly to the pin, and it is on main, so the PR-ref fetch is no longer needed.
michaelzhang-ai
added a commit
that referenced
this pull request
Oct 15, 2026
… commit #44534 dropped the #6042 cherry-pick on the premise that the 2bb549102 pin already contains it. It does not: the pin (Oct 10) predates the #6042 merge (Oct 13). The PR-branch commit 042a28918 conflicts because ROCm/aiter#6159 rewrote pa_decode_sparse.py between the old and new pins. The squash-merge commit 57e2c6b42 sits on top of #6159 and applies cleanly to the pin, and it is on main, so the PR-ref fetch is no longer needed.
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix two leftovers from the AITER pin bump in #44379 that break the AITER build step in
docker/rocm.Dockerfile:\afterpip install -r requirements.txt. [AMD] Update ROCm AITER pin to 2bb549102 #44379 removed the gfx1250git revertblock that followed it but kept the continuation. Dockerfile continuations skip blank and comment lines, so the nextCOPY --from=local_src ...got appended to thepip installcommand (no such option: --from).other=127sed). [CK] Add dsv41 some MoE tuning configs ROCm/aiter#5967 and [Triton/Gluon] Use a zero default for masked scales in gemm_afp8wfp8 ROCm/aiter#6007 are in the new pin2bb549102. The cherry-pick conflicts inpa_decode_sparse.py.Correction: ROCm/aiter#6042 is not in the pin; it merged after it. #44539 restores that patch using its squash-merge commit.
Why
Today's scheduled nightlies failed on every flavor: gfx1250 on (1), and gfx942/gfx950 on (2).
Test plan
release-docker-amd-rocm10.ymldispatched for gfx942-rocm1000 with only fix (1): https://github.com/sgl-project/sglang/actions/runs/38781603589. The AITER step no longer swallowed theCOPY, then failed on the [Triton/Gluon] Avoid the peeled sparse MLA spill on 64-bit gathers below triton 3.8 ROCm/aiter#6042 cherry-pick conflict, which is what surfaced (2).release-docker-amd-rocm10.ymlon main passed for all four images (gfx942, gfx950, gfx1250, gfx1250-rocm101): https://github.com/sgl-project/sglang/actions/runs/38784940437. ROCm 7.2 with [Fix] [AMD] docker: Restore the AITER sparse MLA spill patch on the 2bb549102 pin #44539 on top: https://github.com/sgl-project/sglang/actions/runs/38803779443.